Add __slots__ to typing._NotIterable
#92570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
AlexWaygood
added
skip issue
skip news
type-bug
JelleZijlstra
added
needs backport to 3.11
JelleZijlstra
approved these changes
May 9, 2022
gvanrossum
reviewed
May 9, 2022
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM. (Though didn't we once try to assess the effect of those slots and failed to find any?)
Member
Author
Those were different slots I think :) |
Fidget-Spinner
approved these changes
May 10, 2022
Contributor
|
Thanks @AlexWaygood for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-92617 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 10, 2022
(cherry picked from commit eef47d5) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington
added a commit
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4739997 added
typing._NotIterableas a mixin totyping._SpecialForm, which defines__slots__as an optimisation technique. However,typing._NotIterabledoes not define__slots__, meaning the the__slots__declaration ontyping._SpecialFormis now meaningless, since all base classes must define__slots__in order for a__slots__declaration on a subclass to have any effect.This PR adds
__slots__ = ()totyping._NotIterable.