GH-74116: allow multiple drain waiters for asyncio.StreamWriter #94705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
added
topic-asyncio
needs backport to 3.10
graingert
reviewed
Jul 16, 2022
kumaraditya303
force-pushed
the
multiple-drainers
branch
2 times, most recently
from
efcfd1d to
f6ede6e
Compare
kumaraditya303
requested review from
gvanrossum
and removed request for
ambv and
vstinner
kumaraditya303
force-pushed
the
multiple-drainers
branch
from
03c0e87 to
b14ab8a
Compare
gvanrossum
reviewed
Aug 28, 2022
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Looks okay, I have a nit or two.
Misc/NEWS.d/next/Library/2022-07-09-08-55-04.gh-issue-74116.0XwYC1.rst
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 29, 2022
…pythonGH-94705) (cherry picked from commit e5b2453) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
GH-96395 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 29, 2022
…pythonGH-94705) (cherry picked from commit e5b2453) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
GH-96396 is a backport of this pull request to the 3.10 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Aug 30, 2022
miss-islington
added a commit
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.