Skip to content

gh-96187: Prevent _PyCode_GetExtra to return garbage for negative indexes #96188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

gh-96187: Prevent _PyCode_GetExtra to return garbage for negative indexes #96188

merged 1 commit into from
Aug 23, 2022

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 22, 2022 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from markshannon as a code owner August 22, 2022 20:34
@pablogsal pablogsal added 3.10 only security fixes 3.11 only security fixes 3.12 only security fixes labels Aug 22, 2022
@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes type-bug An unexpected behavior, bug, or error labels Aug 23, 2022
kumaraditya303
kumaraditya303 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markshannon markshannon merged commit 16ebae4 into python:main Aug 23, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Aug 23, 2022

Thanks @pablogsal for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2022
@pablogsal @miss-islington
pythonGH-96187: Prevent _PyCode_GetExtra to return garbage for negati…
0d8e8ad 
…ve indexes (pythonGH-96188)

(cherry picked from commit 16ebae4)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Aug 23, 2022

Sorry, @pablogsal and @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 16ebae4cd4029205d932751f26c719c6cb8a6e92 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 23, 2022
@bedevere-bot
Copy link

bedevere-bot commented Aug 23, 2022

GH-96206 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Aug 23, 2022
@miss-islington @pablogsal
GH-96187: Prevent _PyCode_GetExtra to return garbage for negative ind…
27950d8 
…exes (GH-96188)

(cherry picked from commit 16ebae4)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@pablogsal pablogsal deleted the gh-96187 branch August 23, 2022 12:56
@pablogsal pablogsal mentioned this pull request Aug 23, 2022
Merged
pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 23, 2022
@pablogsal
[3.10] pythonGH-96187: Prevent _PyCode_GetExtra to return garbage for…
c324c10 
… negative indexes (pythonGH-96188).

(cherry picked from commit 16ebae4)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 23, 2022
@bedevere-bot
Copy link

bedevere-bot commented Aug 23, 2022

GH-96210 is a backport of this pull request to the 3.10 branch.

pablogsal added a commit that referenced this pull request Aug 23, 2022
@pablogsal
[3.10] GH-96187: Prevent _PyCode_GetExtra to return garbage for negat…
a6c3f6d 
…ive indexes (GH-96188). (#96210)

(cherry picked from commit 16ebae4)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
mdboom pushed a commit to mdboom/cpython that referenced this pull request Aug 24, 2022
@pablogsal @mdboom
pythonGH-96187: Prevent _PyCode_GetExtra to return garbage for negati…
820e20a 
…ve indexes (pythonGH-96188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@markshannon markshannon

Labels

3.10 only security fixes 3.11 only security fixes 3.12 only security fixes type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @bedevere-bot @kumaraditya303 @markshannon