Skip to content

[3.11] gh-96197: Fix expression when :func:`sys.breakpointhook is missing (gh-96293) #96294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ambv merged 1 commit into from
Oct 5, 2022
Merged

[3.11] gh-96197: Fix expression when :func:`sys.breakpointhook is missing (gh-96293) #96294

ambv merged 1 commit into from
Oct 5, 2022

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 26, 2022 •
edited by bedevere-bot
Loading

(cherry picked from commit 47d406f)

Co-authored-by: Dong-hee Na donghee.na@python.org

@corona10 @miss-islington
pythongh-96197: Fix expression when :func:`sys.breakpointhook is miss…
5a8a943 
…ing (pythongh-96293)

(cherry picked from commit 47d406f)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Aug 26, 2022
@bedevere-bot bedevere-bot mentioned this pull request Aug 26, 2022
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Aug 26, 2022

Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented Aug 26, 2022

Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Aug 26, 2022

Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

miss-islington commented Aug 26, 2022

Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Aug 26, 2022

Status check is done, and it's a success ✅ .

corona10
corona10 reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot

marco-buttu
marco-buttu suggested changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@marco-buttu marco-buttu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in line 160 the reference to sys.breakpointhook should be :func:sys.breakpointhook, to be consistent with the rest of the text. Is it possible to fix also this?

@ambv ambv merged commit 19ec4d4 into python:3.11 Oct 5, 2022
@miss-islington miss-islington deleted the backport-47d406f-3.11 branch October 5, 2022 22:03
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @corona10 @pablogsal
[3.11] gh-96197: Fix expression when :func:`sys.breakpointhook is mis…
2af22d2 
…sing (gh-96293) (#96294)

(cherry picked from commit 47d406f)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments

+1 more reviewer

@marco-buttu marco-buttu marco-buttu requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @marco-buttu @corona10 @ambv @bedevere-bot