gh-96751: Remove dead code from CALL_FUNCTION_EX opcode
#96752
Conversation
Fidget-Spinner
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 6e6fe8a 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Looks like a sound change.
| PyObject *func, *callargs, *kwargs = NULL, *result; | ||
| if (oparg & 0x01) { | ||
| kwargs = POP(); | ||
| if (!PyDict_CheckExact(kwargs)) { |
There was a problem hiding this comment.
Could you add an assert that kwargs is a dict and a short comment explaining why it must be a dict.
There was a problem hiding this comment.
Assert is already there https://github.com/python/cpython/pull/96752/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59deR4723
Right now comment says // DICT_MERGE is called before this opcode.
https://github.com/python/cpython/pull/96752/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59deR4722
I think I can improve it!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks. |
4 participants
CALL_FUNCTION_EXopcode handler #96751