gh-96769: Cover more typing special forms to be unsubclassable #96772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
sobolevn
force-pushed
the
issue-96769
branch
from
12c761b to
e011af1
Compare
gvanrossum
approved these changes
Sep 12, 2022
Member
|
Thanks. Do any of the other reviewers have anything to say? |
JelleZijlstra
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through all
test_cannot_subclasscases and added more assertions.This PR does not include
Annotatedbecause of #96771