bpo-34899: Fix a possible assertion failure due to int_from_bytes_impl()#9705
Merged
serhiy-storchaka merged 2 commits intopython:masterfrom Oct 5, 2018
Merged
Conversation
The _PyLong_FromByteArray() call in int_from_bytes_impl() was unchecked.
Objects/longobject.c
Outdated
| (unsigned char *)PyBytes_AS_STRING(bytes), Py_SIZE(bytes), | ||
| little_endian, is_signed); | ||
| Py_DECREF(bytes); | ||
| if (long_obj == NULL) { |
Member
There was a problem hiding this comment.
This check can be merged with the following check.
if (long_obj != NULL && type != &PyLong_Type) {
serhiy-storchaka
approved these changes
Oct 5, 2018
serhiy-storchaka
added
needs backport to 3.6
type-bug
Contributor
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 5, 2018
…l() (pythonGH-9705) The _PyLong_FromByteArray() call in int_from_bytes_impl() was unchecked. (cherry picked from commit 7bb9cd0) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-9729 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 5, 2018
…l() (pythonGH-9705) The _PyLong_FromByteArray() call in int_from_bytes_impl() was unchecked. (cherry picked from commit 7bb9cd0) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-9730 is a backport of this pull request to the 3.6 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _PyLong_FromByteArray() call in int_from_bytes_impl() was
unchecked.
This is a "skip news" PR.
https://bugs.python.org/issue34899