Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Lib/test/test_threading.py
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,15 @@ def test_init_immutable_default_args(self):
timer1.join()
timer2.join()

def test_daemon_param(self):
# PR 98231: add the daemon parameter to the Timer argument
t = threading.Timer(1, print)
self.assertFalse(t.daemon)
t = threading.Timer(1, print, daemon=False)
self.assertFalse(t.daemon)
t = threading.Timer(1, print, daemon=True)
self.assertTrue(t.daemon)

def _callback_spy(self, *args, **kwargs):
self.callback_args.append((args[:], kwargs.copy()))
self.callback_event.set()
Expand Down
4 changes: 2 additions & 2 deletions Lib/threading.py
Original file line number Diff line number Diff line change
Expand Up @@ -1387,8 +1387,8 @@ class Timer(Thread):

"""

def __init__(self, interval, function, args=None, kwargs=None):
Thread.__init__(self)
def __init__(self, interval, function, args=None, kwargs=None, *, daemon=None):
Thread.__init__(self, daemon=daemon)
self.interval = interval
self.function = function
self.args = args if args is not None else []
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a daemon keyword-only argument to the :class:`threading.Timer` constructor, to pass it to the inherited :class:`threading.Thread` constructor.