Use more precise exception types in assertRaises in typing tests
#98650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
AlexWaygood,
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
JelleZijlstra
added
needs backport to 3.11
Contributor
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 25, 2022
…ythonGH-98650) (cherry picked from commit 45c8935) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-98655 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 25, 2022
…ythonGH-98650) (cherry picked from commit 45c8935) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-98656 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptionbase-class is too broad, literally anything can be thrown.We can be more precise with using
TypeErrorinstead: this is exactly what is thrown.Going to skip issue for this, it is very minor.