gh-99051: remove duplicated test from test_weakref

[sobolevn]

• Issue: test_weakref contains two identical test cases #99051

[Jason-Y-Z]

Given that all Python 3 classes inherit from object by default, this looks good.
A slight comment would be maybe we want to update the test names since we now jump from test_callback_in_cycle_1 to test_callback_in_cycle_3.

[iritkatriel]

Note that this comment in test_callback_in_cycle_3 becomes obsolete if we merge this as it is now:

"# This one broke the first patch that fixed the last two."

Can you think of more meaningful suffixes for these test names than a number?

Also, maybe remove the (object) in the class definitions in the other tests while we're clearing up old-style classes?

[sobolevn]

Can you think of more meaningful suffixes for these test names than a number?

Yes, this is a good suggestion. Thank you.
I've used more semantic names.

Also, maybe remove the (object) in the class definitions in the other tests while we're clearing up old-style classes?

I would prefer to keep it as-is, because there's no semantical difference.
And style-only diffs are not something I would like to see in a git blame :)

[iritkatriel]

Looks good, just one nit about the comment.

[miss-islington]

Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

[bedevere-bot]

GH-99170 is a backport of this pull request to the 3.11 branch.

[bedevere-bot]

GH-99171 is a backport of this pull request to the 3.10 branch.

[sobolevn]

Thanks again! 👍