Skip to content

[Skip Issue] Fix several reference counting bugs in pyexpat.c#9955

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
ZackerySpytz:pyexpat-ref-counting-bugs
Oct 19, 2018
Merged

[Skip Issue] Fix several reference counting bugs in pyexpat.c#9955
serhiy-storchaka merged 1 commit into
python:masterfrom
ZackerySpytz:pyexpat-ref-counting-bugs

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

Some Py_BuildValue() failures were not handled correctly, and there
were some missing Py_DECREF()s.

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you @ZackerySpytz!

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2018
(cherry picked from commit 68def05)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-9962 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2018
(cherry picked from commit 68def05)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-9963 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2018
(cherry picked from commit 68def05)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-9964 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Oct 19, 2018
(cherry picked from commit 68def05)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Oct 19, 2018
(cherry picked from commit 68def05)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Oct 19, 2018
(cherry picked from commit 68def05)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants