Skip to content

Conversation

@willingc
Copy link
Contributor

@willingc willingc commented May 8, 2016

Addresses #7.

Edits content to improve clarity and usability by sprint leaders. Improves user friendliness of document's tone.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

Unfortunately we couldn't find an account corresponding
to your GitHub username at bugs.python.org (b.p.o).
If you don't already have an account at b.p.o, please
create one and make sure to
add your GitHub username. If you do already have an account at b.p.o then
please go there and under "Your Details" add your GitHub username.

And in case you haven't already, please make sure to sign the
PSF contributor agreement
(CLA); we can't legally look at your contribution until you have signed the
CLA.

Once you have done everything that's needed, please reply here and someone will
verify everything is in order.

@willingc
Copy link
Contributor Author

willingc commented May 8, 2016

Well, the tool caught that I did not have a GitHub address in my bugs.python.org account even though I do have a signed CLA. I've updated the bugs.python.org account to include my GitHub user name.

I will push a small change to my PR branch and see if this resolves the CLA not signed tag.

@willingc
Copy link
Contributor Author

willingc commented May 8, 2016

Ooh. Very cool. The tool did change to CLA signed tag on a push to the branch. Nicely implemented.

Perhaps consider changing the default error message when there is no GitHub address in the bugs.python.org account so that a contributor can resolve themselves and not require interaction from a developer.

LLVM + clang as this provides better error reporting than gcc.

For Windows users, tell them to download and install Visual C++ Express
For Windows users, ask them to download and install Visual C++ Express
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is outdated (it's Visual Studio Community edition now)

I'll fix that directly after merging.

@ncoghlan ncoghlan merged commit 8c36f62 into python:master May 9, 2016
@ncoghlan
Copy link
Collaborator

ncoghlan commented May 9, 2016

Couple of fix-ups suggested, but I'll do those myself post-merge.

@willingc
Copy link
Contributor Author

willingc commented May 9, 2016

Thanks @ncoghlan. Also thank you to who wrote the CLA tool. It worked out very well 😄

@willingc willingc deleted the edit-readme branch May 9, 2016 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants