tomllib may raise exceptions other than TOMLDecodeError#20
Merged
StanFromIreland merged 4 commits intopython:mainfrom Apr 5, 2026
Merged
tomllib may raise exceptions other than TOMLDecodeError#20StanFromIreland merged 4 commits intopython:mainfrom
tomllib may raise exceptions other than TOMLDecodeError#20StanFromIreland merged 4 commits intopython:mainfrom
Conversation
ezio-melotti
approved these changes
Apr 5, 2026
pablogsal
approved these changes
Apr 5, 2026
Member
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
Nit: instead of adding a catch per exception you can make a global variable with a tuple of all of them and catch the tuple
Member
Author
|
Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fuzz has been failing on
RecursionErrors in CPython, e.g. https://github.com/python/cpython/actions/runs/23989203001/job/69969245811. I also added all of the other exceptions the module can raise.