Conversation
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
I'm not familiar with this codebase, but the configuration seems fine to me (and I'd like to see JIT memory tracking)!
Do we also need to ensure somewhere that LLVM is installed?
| "flags": ["--enable-experimental-jit=yes"], | ||
| "description": "Just-In-Time compilation enabled.", | ||
| "color": "#fc03df", | ||
| "icon": "zap", |
There was a problem hiding this comment.
Is this icon supposed to be unique? Looks like both PGO and nogil are using the same zap icon.
There was a problem hiding this comment.
Nah, is just the icon that is used when displayed here: https://memory.python.org/binaries
it can be changed later in the admin panel
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Good point. I've added that (cribbed from https://github.com/python/cpython/blob/main/.github/workflows/jit.yml) |
| "flags": ["--enable-experimental-jit=yes"], | ||
| "description": "Just-In-Time compilation enabled.", | ||
| "color": "#fc03df", | ||
| "icon": "zap", |
There was a problem hiding this comment.
Nah, is just the icon that is used when displayed here: https://memory.python.org/binaries
it can be changed later in the admin panel
|
Thanks a lot @mdboom ! |
3 participants
Adds support for building binaries with the JIT.
Cc: @brandtbucher