-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Open
Labels
Description
Feature
I think it would be great if mypy supported control flow analysis of aliased conditions like, e.g., introduced in TypeScript v4.4.
Currently, mypy works as follows:
from typing import Sequence, Union
def f(value: Union[str, Sequence[str]]):
is_string = isinstance(value, str)
if is_string:
reveal_type(value) # Revealed type is "Union[builtins.str, typing.Sequence[builtins.str]]"
else:
reveal_type(value) # Revealed type is "Union[builtins.str, typing.Sequence[builtins.str]]"But it would be nice if it could infer the type of value correctly in the condition:
from typing import Sequence, Union
def f(value: Union[str, Sequence[str]]):
is_string = isinstance(value, str)
if is_string:
reveal_type(value) # Revealed type is "builtins.str"
else:
reveal_type(value) # Revealed type is "typing.Sequence[builtins.str]"Pitch
See, e.g., copier-org/copier#812:
def _execute_tasks(self, tasks: Sequence[Task]) -> None:
# ...
for i, task in enumerate(tasks):
task_cmd = task.cmd
if isinstance(task_cmd, str):
task_cmd = self._render_string(task_cmd)
use_shell = True
else:
task_cmd = [self._render_string(str(part)) for part in task_cmd]
use_shell = False
# ...
with local.cwd(self.subproject.local_abspath), local.env(**task.extra_env):
subprocess.run(task_cmd, shell=use_shell, check=True, env=local.env)It would be nice to rewrite the above snippet as follows:
def _execute_tasks(self, tasks: Sequence[Task]) -> None:
# ...
for i, task in enumerate(tasks):
task_cmd = task.cmd
+ use_shell = isinstance(task_cmd, str)
+ if use_shell:
- if isinstance(task_cmd, str):
task_cmd = self._render_string(task_cmd)
- use_shell = True
else:
task_cmd = [self._render_string(str(part)) for part in task_cmd]
- use_shell = False
# ...
with local.cwd(self.subproject.local_abspath), local.env(**task.extra_env):
subprocess.run(task_cmd, shell=use_shell, check=True, env=local.env)Reactions are currently unavailable