Skip to content

Incorrect handling of import from namespace package that spans site-packages and the source tree #14822

@sfc-gh-zpeng

Description

@sfc-gh-zpeng

Bug Report

The following command:

mypy --explicit-package-bases ns_package/sub_ns_package1/test.py

Resulted in

ns_package/sub_ns_package1/test.py:1: error: Module "ns_package" has no attribute "sub_ns_package2"  [attr-defined]
Found 1 error in 1 file (checked 1 source file)

With the following setup:

Source code tree:

ns_package
    sub_ns_package1
        test.py

(note that there is no __init__.py)

site-packages tree (partial):

ns_package
    sub_ns_package2
        module.py    

(same, no __init__.py)

test.py contents:

from ns_package import sub_ns_package2

While scratching my head I also found the following:

  • import sub_ns_package.ns_package2 works.
  • it also works if the above import appears together with from ns_package import sub_ns_package2

To Reproduce
See the above.

Expected Behavior

mypy should finish happily in the above example.

Actual Behavior

ns_package/sub_ns_package1/test.py:1: error: Module "ns_package" has no attribute "sub_ns_package2"  [attr-defined]
Found 1 error in 1 file (checked 1 source file)

Your Environment

  • Mypy version used: 1.0.1
  • Mypy command-line flags: --explicit-package-bases (tried with or without it) ; --namespace-packages (tried with or without it)
  • Mypy configuration options from mypy.ini (and other config files): N/A
  • Python version used: 3.8.16

Potential Fix
I have very little knowledge about the codebase, but the following patch would make the problem go away. I'm not sure it's the right fix though.

e69bbd2

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugmypy got something wrong

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions