[mypyc] Move mypyc singledispatch support into new file #12517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all of the singledispatch-related functions in mypyc/irbuild/function.py into a separate file just for singledispatch-related functionality. This also adds documentation about how mypyc's support for singledispatch works.
Move the code for the pass that looks for singledispatch functions and corresponding register calls into singledispatch.py. This also adds some documentation about why we need a separate pass for looking for singledispatch functions instead of just adding this searching to one of the already existing passes. This also fixes some circular imports caused by moving functions into singledispatch.py.
Fix a flake8 "line too long" error
JukkaL
reviewed
Apr 4, 2022
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks, this is a good idea. Left one comment about avoiding an import cycle, otherwise looks good.
Move the definition of RegisterImplInfo and SingledispatchInfo into util.py so that we can use those types in builder.py without builder.py having to import singledispatch.py (which would bring function.py, builder.py, and singledispatch.py into the same import cycle).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
singledispatchfunctions into a new file so that it's all in one place instead of being spread out between function.py and prepare.pyget_registry_identifierfunctionTest Plan
This is a refactoring PR, so I think making sure the current tests pass should be enough.