Stubtest: verify default values for Final variables in a stub
#14568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Jan 31, 2023
AlexWaygood
commented
Feb 2, 2023
ichard26
reviewed
Feb 25, 2023
| if fallback.fullname == "builtins.str": | ||
| stub_value = node_for_stub_value.value | ||
| elif fallback.fullname == "builtins.bytes": | ||
| stub_value = bytes(node_for_stub_value.value, "utf-8") |
Collaborator
There was a problem hiding this comment.
I don't know about these codecs to decide whether this is an actual problem, but FWIW mypyc converts BytesExpr.value into bytes in a bit more involved way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a9c62c5, stubtest now verifies parameter defaults in a stub (when they're present). However, if a global or class variable in a stub has a default value, stubtest currently does no verification of the value (only the type).
Unfortunately, it seems like mypy does not store the value for most variable assignments, so it is hard to verify the value. However, it does store the value for
Finalvariables.