Respect force-union-syntax flag in error hint #20165
Merged
+12
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
commented
Nov 2, 2025
Comment on lines
-143
to
144
| if "union-error" not in testcase.file: | ||
| if "union-error" not in testcase.file and "Pep604" not in testcase.name: | ||
| options.force_union_syntax = True |
There was a problem hiding this comment.
Special case for testSuggestPep604AnnotationForPartialNone. This will be removed once all tests are updated to just use the the PEP 604 syntax.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error hint for
Need type annotations for ...should defer tooptions.use_union_syntaxwhen evaluating ifUnionor|should be used. This will also make it easier to eventually upgrade all tests to use the PEP 604 syntax.