Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mypy/semanal.py
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,15 @@ def add_implicit_module_attrs(self, file_node: MypyFile) -> None:
else:
inst = self.named_type_or_none("importlib.machinery.ModuleSpec")
if inst is None:
if self.final_iteration:
if (
self.final_iteration
or self.options.clone_for_module("importlib.machinery").follow_imports
== "skip"
):
# If we are not allowed to resolve imports from `importlib.machinery`,
# ModuleSpec will not be available at any iteration.
# Use the fallback earlier.
# (see https://github.com/python/mypy/issues/18237)
inst = self.named_type_or_none("builtins.object")
assert inst is not None, "Cannot find builtins.object"
else:
Expand Down
18 changes: 18 additions & 0 deletions test-data/unit/cmdline.test
Original file line number Diff line number Diff line change
Expand Up @@ -1393,3 +1393,21 @@ Ts = TypeVarTuple("Ts")
Warning: TypeVarTuple is already enabled by default
Warning: Unpack is already enabled by default
== Return code: 0

[case testImportlibImportCannotBeResolved]
# cmd: mypy a.py
# This test is here because it needs use_builtins_fixtures off.

[file a.py]
from typing import NamedTuple

class CodecKey(NamedTuple):
def foo(self) -> "CodecKey":
...

[file mypy.ini]
\[mypy]

\[mypy-importlib.*]
follow_imports = skip
follow_imports_for_stubs = True