Treat Literal["xyz"] as iterable #20347
Open
+35
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra condition that excluded LiteralType was introduced in python#14827 I see no particular reason to have an instance check at all I was looking at this because of this comment from Emma python#15511 (comment) Previously we errored with `"Literal['xy']" object is not iterable` which is of course totally false Now I issue the same error as in the str case, but restrict to cases where the unpack length does not match
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/blocks/core.py:1204: error: R? object is not iterable [misc]
- src/prefect/blocks/core.py:1261: error: R? object is not iterable [misc]
- src/prefect/blocks/core.py:1264: error: R? object is not iterable [misc]
+ src/prefect/blocks/core.py:1204: error: R? has no attribute "__iter__" (not iterable) [attr-defined]
+ src/prefect/blocks/core.py:1261: error: R? has no attribute "__iter__" (not iterable) [attr-defined]
+ src/prefect/blocks/core.py:1264: error: R? has no attribute "__iter__" (not iterable) [attr-defined]
- src/prefect/server/database/query_components.py:170: error: R? object is not iterable [misc]
+ src/prefect/server/database/query_components.py:170: error: R? has no attribute "__iter__" (not iterable) [attr-defined]
- src/prefect/server/database/query_components.py:182: error: Cannot determine type of "scheduled_flow_runs" [has-type]
- src/prefect/server/database/query_components.py:190: error: Cannot determine type of "scheduled_flow_runs" [has-type]
- src/prefect/server/database/query_components.py:190: error: Cannot determine type of "join_criteria" [has-type]
- src/prefect/server/database/query_components.py:196: error: Cannot determine type of "scheduled_flow_runs" [has-type]
- src/prefect/server/database/query_components.py:197: error: Cannot determine type of "scheduled_flow_runs" [has-type]
porcupine (https://github.com/Akuli/porcupine)
+ porcupine/plugins/directory_tree.py:414: error: Unsupported operand types for + ("int" and "str") [operator]
+ porcupine/plugins/directory_tree.py:414: note: Right operand is of type "int | str"
+ porcupine/plugins/directory_tree.py:415: error: Unsupported operand types for + ("int" and "str") [operator]
+ porcupine/plugins/directory_tree.py:415: note: Right operand is of type "int | str"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra condition that excluded LiteralType was introduced in #14827. I see no particular reason to have an instance check at all
I was looking at this because of this comment from Emma #15511 (comment) Previously we errored with
"Literal['xy']" object is not iterablewhich is of course totally falseNow I issue the same error as in the str case, but restrict to cases where the unpack length does not match
Related to #20325