fix: optimize overloaded signatures check #20378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may take a while to expand all the variants for parametrized classes. So we should expand other's callable variants only once. Refs: nipunn1313/mypy-protobuf#707
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed numerous calls to
expand_callable_variantsduring the investigation of the related issue. However, expanding all the variants for parametrized classes can be time-consuming. Therefore, we should only expand callable variants once. This optimization reduces the processing time from approximately 400 seconds to 7 seconds when using non-compiled mypy in the provided case.Refs: nipunn1313/mypy-protobuf#707