[mypyc] Add experimental librt.time module with time() #20723
Merged
+317
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
p-sawicki
approved these changes
Feb 2, 2026
| extra_compile_args=cflags, | ||
| ), | ||
| Extension( | ||
| "librt.time", ["time/librt_time.c"], include_dirs=["."], extra_compile_args=cflags |
Collaborator
There was a problem hiding this comment.
add "time" to include_dirs?
Collaborator
Author
There was a problem hiding this comment.
It seems fine to requite time/ prefix in includes.
| ["vecs/librt_vecs.h", "vecs/vec_template.c"], | ||
| ["vecs"], | ||
| ), | ||
| ModDesc("librt.time", ["time/librt_time.c"], ["time/librt_time.h"], []), |
Collaborator
There was a problem hiding this comment.
also would make sense to add the include dir here.
Collaborator
Author
There was a problem hiding this comment.
Currently everything works without the include dir, so I'm leaning towards keeping it as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen many performance-critical functions that have calls to
time.time(), which is perhaps not that surprising. I don't want to just add a primitive fortime.time(), since it's often monkey patched, and primitive functions generally can't be monkey patched. Instead, I add thelibrt.timemodule here, which has an efficienttime()function that can be used in performance-critical code (but it can't be monkey patched).In a microbenchmark this was up to 70% faster than using
time.time().I used a lot of coding agent assist. I'm relying on CI to test the Windows implementation.