Skip to content

Add function definition notes for more call argument errors #20794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KevinRK29 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add function definition notes for more call argument errors #20794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mypy/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,17 +961,20 @@ def too_few_arguments(
else:
msg = "Too few arguments" + for_function(callee)
self.fail(msg, context, code=codes.CALL_ARG)
self.note_defined_here(callee, context)

def missing_named_argument(self, callee: CallableType, context: Context, name: str) -> None:
msg = f'Missing named argument "{name}"' + for_function(callee)
self.fail(msg, context, code=codes.CALL_ARG)
self.note_defined_here(callee, context)

def too_many_arguments(self, callee: CallableType, context: Context) -> None:
if self.prefer_simple_messages():
msg = "Too many arguments"
else:
msg = "Too many arguments" + for_function(callee)
self.fail(msg, context, code=codes.CALL_ARG)
self.note_defined_here(callee, context)
self.maybe_note_about_special_args(callee, context)

def too_many_arguments_from_typed_dict(
Expand All @@ -993,6 +996,7 @@ def too_many_positional_arguments(self, callee: CallableType, context: Context)
else:
msg = "Too many positional arguments" + for_function(callee)
self.fail(msg, context)
self.note_defined_here(callee, context)
self.maybe_note_about_special_args(callee, context)

def maybe_note_about_special_args(self, callee: CallableType, context: Context) -> None:
Expand Down Expand Up @@ -1035,6 +1039,10 @@ def unexpected_keyword_argument(
self.unexpected_keyword_argument_for_function(
for_function(callee), name, context, matches=matches
)
self.note_defined_here(callee, context)

def note_defined_here(self, callee: CallableType, context: Context) -> None:
"""Add a note pointing to the definition of the callee."""
module = find_defining_module(self.modules, callee)
if module:
assert callee.definition is not None
Expand Down
Loading