Speed up suppressed deps options processing#20806
Merged
Conversation
`suppressed_deps_opts` was consuming 5% of total CPU in a small incremental run targeting a very large codebase. Make it faster by avoiding json dump, and overall using a more efficient encoding. We could still make this faster by encoding the options as a single integer, but maybe this is already good enough.
JukkaL
changed the title
ilevkivskyi
approved these changes
Feb 13, 2026
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
I guess you didn't read my comment in #20800 earlier this morning :-)
Btw we may want to micro-optimize that one as well for large code bases that use --follow-imports=skip, LOL. I can do this while fixing this issue
Anyway, I didn't start working on this yet, so no merge conflicts.
Collaborator
Author
Oops, missed that one. But this wasn't much effort anyway. |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
suppressed_deps_optswas consuming 5% of total CPU in a small incremental run targeting a very large codebase. Make it faster by avoiding json dump, and overall using a more efficient encoding.We could still make this faster by encoding the options as a single integer, but maybe this is already good enough.