Skip to content

Unskip parse error tests#21005

Merged
hauntsaninja merged 2 commits intopython:masterfrom
hauntsaninja:parserrors
Mar 11, 2026
Merged

Unskip parse error tests#21005
hauntsaninja merged 2 commits intopython:masterfrom
hauntsaninja:parserrors

Conversation

@hauntsaninja
Copy link
Collaborator

No description provided.

@hauntsaninja hauntsaninja marked this pull request as ready for review March 11, 2026 03:04
@hauntsaninja hauntsaninja merged commit 33f4ae3 into python:master Mar 11, 2026
17 checks passed
@hauntsaninja hauntsaninja deleted the parserrors branch March 11, 2026 03:04
Copy link
Collaborator

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not very important comment!)

try:
options = parse_options("\n".join(testcase.input), testcase, 0)
if options.python_version < defaults.PYTHON3_VERSION:
options.python_version = defaults.PYTHON3_VERSION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be impossible? The options should default to sys.version_info and at very worst this should trigger?

Copy link
Collaborator Author

@hauntsaninja hauntsaninja Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is other test-specific code that sets it to defaults.PYTHON3_VERSION_MIN (which is lower than PYTHON3_VERSION). Grep for testfile_pyversion

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oops, I actually misread that (as only referring to defaults.PYTHON3_VERSION, oops).

Thanks! Makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants