Allow ParamSpec in NamedTuple and TypedDict#21044
Open
A5rocks wants to merge 1 commit intopython:masterfrom
Open
Allow ParamSpec in NamedTuple and TypedDict#21044A5rocks wants to merge 1 commit intopython:masterfrom
A5rocks wants to merge 1 commit intopython:masterfrom
Conversation
A5rocks
commented
Mar 19, 2026
| def __len__(self) -> int: ... | ||
| def count(self, obj: object) -> int: ... | ||
|
|
||
| class _ItemsView(Iterable[Tuple[KT, VT]]): ... |
Collaborator
Author
There was a problem hiding this comment.
I was getting this error:
tmp/builtins.pyi:54: error: Class builtins._ItemsView has abstract attributes "__iter__" (diff)
tmp/builtins.pyi:54: note: If it is meant to be abstract, add 'abc.ABCMeta' as an explicit metacl[snipped]
due to how full typing + this were interacting. I didn't feel like investigating, so I just inlined this type.
Collaborator
Author
|
Looks like a flakey test failure? |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21039. These were TODOs and I'm not completely sure we should expose this, but obviously there's demand.