Better narrowing for enums and other types with known equality#21281
Open
hauntsaninja wants to merge 1 commit intopython:masterfrom
Open
Better narrowing for enums and other types with known equality#21281hauntsaninja wants to merge 1 commit intopython:masterfrom
hauntsaninja wants to merge 1 commit intopython:masterfrom
Conversation
9703471 to
e61527c
Compare
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: rich (https://github.com/Textualize/rich)
+ rich/console.py:1542: error: Redundant cast to "Literal['left', 'center', 'right']" [redundant-cast]
cryptography (https://github.com/pyca/cryptography)
+ src/cryptography/hazmat/primitives/serialization/ssh.py:1120: error: Argument 16 to "SSHCertificate" has incompatible type "bytes | Any | memoryview[int]"; expected "bytes" [arg-type]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21187, fully fixes this comment #9003 (comment) (previously improved on in 1.20 narrowing changes)
This diff adds general functionality that replaces a few different pieces of ad hoc logic:
--strict-bytes. We also no longer have to mark memoryview and bytearray as having custom equality implementations. That is, it is a long term fix for Optional bytes type not narrowed after asserting equality #20701Co-authored-by Codex