Fail fast when user tries to generate reports with parallel workers#21341
Merged
ilevkivskyi merged 3 commits intopython:masterfrom Apr 27, 2026
Merged
Fail fast when user tries to generate reports with parallel workers#21341ilevkivskyi merged 3 commits intopython:masterfrom
ilevkivskyi merged 3 commits intopython:masterfrom
Conversation
Member
Author
|
Opened #21342 to track support for reports in parallel mode. |
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Apr 27, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Maybe create an issue about supporting report generation in parallel mode?
| if options.cache_dir == os.devnull: | ||
| fail("error: cache must be enabled in parallel mode", stderr, options) | ||
| if options.report_dirs: | ||
| fail("error: reports are not supported in parallel mode yet", stderr, options) |
Collaborator
There was a problem hiding this comment.
Suggest using -n0 to disable parallel mode (in case it's picked up from the config file, so user might not remember how to do it)?
Member
Author
Already did, see above. |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not supported, and support is somewhat non-trivial, so fail fast instead of generating incomplete/empty reports.
cc @JukkaL