Make new parser consistent with the old one#21377
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Apr 30, 2026
Merged
Conversation
hauntsaninja
approved these changes
Apr 29, 2026
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
|
Would it be possible for this to be backported to 1.20? We're interested in using the native parser now for the perf wins. Thanks for considering! A |
JukkaL
pushed a commit
that referenced
this pull request
Apr 30, 2026
This fixes some issues discovered in #21331 Two things here: * Old parser keeps `metaclass` in keywords, so it is better to keep it in the new one as well * Old parser has right-associativity for BoolOps, so should have the new one If we want to have the new behavior for some reason, it is possible to instead make some fixes "downstream" in semantic analysis/type-checking/etc. _But_, it is non-trivial, and IMO it is not a good time to change the behavior while we still have both parsers. Note I don't add test for the metaclass change because a whole bunch of mypyc tests fails with new parser already without this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some issues discovered in #21331
Two things here:
metaclassin keywords, so it is better to keep it in the new one as wellIf we want to have the new behavior for some reason, it is possible to instead make some fixes "downstream" in semantic analysis/type-checking/etc. But, it is non-trivial, and IMO it is not a good time to change the behavior while we still have both parsers.
Note I don't add test for the metaclass change because a whole bunch of mypyc tests fails with new parser already without this PR.
cc @JukkaL