Update TypedDictType.__init__ signature to preserve backward compat#21590
Merged
Conversation
The new signature added a new parameter in the middle of the signature, which may break plugins that use positional arguments. Add the new parameter to the end of the parameter list so that existing calls will continue to work. This looks a bit ugly, but backward compatibility is the priority here.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new signature added a new parameter in the middle of the signature,
which may break plugins. Add the new parameter to the end of the parameter
list with a default value so that existing calls will continue to work. This looks
a bit ugly, but backward compatibility is the priority here.