Add support for additional type aliases from collections #2845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JelleZijlstra Thanks! I don't think many additional test are needed, maybe just few tests showing errors (like |
gvanrossum
changed the title
|
I guess I'll have to sync typeshed first, then you can merge that into this PR, and then the tests ought to pass and it can be merged. |
Merged
|
Done. Can you merge from master and re-push? |
I didn't add detailed tests for these since there's little specific to these classes in mypy's code. I can add more detailed tests like those for defaultdict if that is preferred. This PR depends on these two typeshed PRs: - python/typeshed#929 - python/typeshed#928
JelleZijlstra
force-pushed
the
collections
branch
from
69f3763 to
574586b
Compare
|
Done. Thanks for taking care of the sync! |
|
I've tested this patch on my own code and it works fine. I think it is ready to apply. |
|
OK, merged. Sorry for the delay, I'm still dealing with health issues and not my usual responsive self. |
|
Thanks! No hurry. |
umkay
added a commit
to umkay/zulip
that referenced
this pull request
May 22, 2017
In the future, the type annotation should use Deque in order to be compatible with the latest mypy version. Contingent on python/mypy#2845 being merged.
umkay
added a commit
to umkay/zulip
that referenced
this pull request
May 22, 2017
In the future, the type annotation should use Deque in order to be compatible with the latest mypy version. See python/mypy#2845 for more info.
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
May 23, 2017
In the future, the type annotation should use Deque in order to be compatible with the latest mypy version. See python/mypy#2845 for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements python/typing#366 in mypy.
I didn't add detailed tests for these since there's little specific
to these classes in mypy's code. I can add more detailed tests
like those for defaultdict if that is preferred.
This PR depends on these two typeshed PRs [Update: both merged]: