allow instantiating ChainMap #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to refuse to instantiate ChainMap, because it has unimplemented abstract methods. This PR adds the abstract methods to the stub, which is enough to persuade mypy to allow me to instantiate a ChainMap.
JelleZijlstra
added a commit
to JelleZijlstra/mypy
that referenced
this pull request
Feb 11, 2017
I didn't add detailed tests for these since there's little specific to these classes in mypy's code. I can add more detailed tests like those for defaultdict if that is preferred. This PR depends on these two typeshed PRs: - python/typeshed#929 - python/typeshed#928
ilevkivskyi
approved these changes
Feb 11, 2017
JelleZijlstra
added a commit
to JelleZijlstra/mypy
that referenced
this pull request
Feb 12, 2017
I didn't add detailed tests for these since there's little specific to these classes in mypy's code. I can add more detailed tests like those for defaultdict if that is preferred. This PR depends on these two typeshed PRs: - python/typeshed#929 - python/typeshed#928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR led mypy to refuse to instantiate ChainMap, because it has unimplemented
abstract methods. This PR adds the abstract methods to the stub,
which is enough to persuade mypy to allow me to instantiate a
ChainMap.