Revert reveal_type message fix #3267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also fixes #3236 by deleting all the code in question. |
Member
|
I tried this with both crash scenarios and in both Python 2 and Python 3 modes (also combinations of PY2 in first Lets hope this will finally fix the problems (in any case the renaming code looks too ad-hoc, so I am glad to remove it). |
Member
|
Thanks! I can no longer repro this in our own codebase either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3259.
#3202, #3232, #3259 were all caused by a feature introduced in #3107 that changed
reveal_typemessage from_importlib_modulespec.ModuleTypetotypes.ModuleTypeetc. My attempts to fix those issues with #3205 and #3235 were no good. I revert #3205 and #3235, and the feature itself.