MANIFEST.in: simplify and robust-ify #9592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something we seem to struggle with, eg see #9587 and #8949
This PR helps prevent these mistakes from happening by using a simpler rule for file inclusions. If we create more pure Python mypyc subpackages, we should no longer have to make an update here.
The other thing this does is get things passing with https://github.com/mgedmin/check-manifest. This tool compares what you've checked in to git with what gets added to an sdist. We now pass cleanly (meaning we should be adding everything we need). I was also careful to examine the output of check-manifest before this change (meaning that we shouldn't be adding many things we previously did not add).
Since in the new wheel building scripts that I created for #9536 we also now create an sdist, I'll add a step that runs check-manifest when it gets merged.
Also delete a symlink to a file that doesn't seem to exist anymore and some other cruft.