PEP 345: Improve example for the Project-URL field and clarify purpose #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@di care to approve this in case it affects PEP 566? |
di
approved these changes
Oct 24, 2019
|
Dustin, updated with your suggestions, feel free to squash and merge if happy. |
|
@wimglenn thanks for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Project-URL section is a bit weak:
Description was improved in PEP-0459 but that was withdrawn.
Likely the strange wording in this section was due to historical reasons: in 0ed1ae3 three separate fields (
Repository-URL,Repository-Browser-URL,Bug-Tracker-URL) were consolidated intoProject-URL(multiple use).I've tried to update the description/example and make it more useful.