Skip to content

Conversation

@gustavgransbo
Copy link
Contributor

This resolves #2868.

@ghost
Copy link

ghost commented Nov 6, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@AA-Turner AA-Turner merged commit 5e6cef7 into python:main Nov 6, 2022
@AA-Turner
Copy link
Member

Impressively, merging this managed to create an empty commit -- some sort of race condition in GitHub's logic perhaps?

The offending commit: 5e6cef7

A

@CAM-Gerlach
Copy link
Member

Never seen that happen before—I've reported it. Seems this is also missing a Resolution header, as many PEPs are.

@JelleZijlstra
Copy link
Member

@AA-Turner it's probably fine but I'd have waited for a few days to give the PEP owner a chance to say that we should wait. Some PEPs may have rough corners that aren't immediately apparent and that still need to be finalized. No need to revert though, unless the PEP owner actually asks for it.

@AA-Turner
Copy link
Member

Ahh, I got slightly mixed up and thought Eric was the author of 616, rather than the sponsor -- thank you for the note!

A

@AA-Turner
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark PEP 616 as Final

4 participants