Skip to content

PEP 718: Subscriptable functions#3179

Merged
hugovk merged 13 commits intopython:mainfrom
Gobot1234:subscriptable-functions
Jul 31, 2023
Merged

PEP 718: Subscriptable functions#3179
hugovk merged 13 commits intopython:mainfrom
Gobot1234:subscriptable-functions

Conversation

@Gobot1234
Copy link
Copy Markdown
Contributor

@Gobot1234 Gobot1234 commented Jun 23, 2023

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

📚 Documentation preview 📚: https://pep-previews--3179.org.readthedocs.build/

@Gobot1234 Gobot1234 requested a review from a team as a code owner June 23, 2023 20:04
@Gobot1234
Copy link
Copy Markdown
Contributor Author

CC @gvanrossum

Comment thread pep-0718.rst Outdated
Co-authored-by: Chris Angelico <rosuav@gmail.com>
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am sponsoring this PEP!

Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst
Comment thread pep-0718.rst
Comment thread pep-0718.rst
Comment thread pep-0718.rst
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst
Comment thread pep-0718.rst Outdated
Copy link
Copy Markdown
Contributor Author

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, might be a bit slow to respond to the rest of the comments I'm currently on a canal :)

Comment thread pep-0718.rst Outdated
Comment thread pep-0718.rst Outdated
Gobot1234 and others added 5 commits July 15, 2023 01:05
@Gobot1234
Copy link
Copy Markdown
Contributor Author

Is there anything that is stopping this being merged?

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Jul 31, 2023

No, let's merge it so you can refer to it at https://peps.python.org/pep-0718/.

@hugovk hugovk merged commit 16e35f5 into python:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants