Skip to content

Comments

PEP 742: Add Discussions-To; use TypeIs#3665

Merged
JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra:pep742
Feb 16, 2024
Merged

PEP 742: Add Discussions-To; use TypeIs#3665
JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra:pep742

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Feb 14, 2024

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--3665.org.readthedocs.build/

Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(my reservation with TypeIs is that (x: object) -> TypeIs[str] sound like it implies type(x) is str. Exact type is sometimes a useful thing...)

@JelleZijlstra JelleZijlstra merged commit b9cc1fc into python:main Feb 16, 2024
@JelleZijlstra
Copy link
Member Author

@hauntsaninja if you feel strongly enough about this, please share your opinion on Discourse. I'm open to reconsidering the name if there is community consensus going another way.

@JelleZijlstra JelleZijlstra deleted the pep742 branch February 16, 2024 01:16
@JelleZijlstra JelleZijlstra restored the pep742 branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants