-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Tests: Improve tests and coverage configuration #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We have the config for each tool in its own config file, except coverage is piggybacking on tox.ini.
Shall we put coverage it its own file too? Or use a pyproject.toml for them all?
| [coverage:report] | ||
| exclude_also = | ||
| if __name__ == .__main__.: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also skip/omit/exclude release_management/__main__.py as suggested in #4704?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that already covered by the blanket exclusion?
A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged this to pull it into #4705 to test, it appears that the blanket exclusion does work, but only if there are no comments on the same line. I can't find anything in coverage's docs or GH issues about comments either way. Sorry for my error here!
|
A |
cc @hugovk
This also uses the new support in pytest 9.0 for
.pytest.toml.A
📚 Documentation preview 📚: https://pep-previews--4715.org.readthedocs.build/