Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Nov 24, 2025

cc @hugovk

This also uses the new support in pytest 9.0 for .pytest.toml.

A


📚 Documentation preview 📚: https://pep-previews--4715.org.readthedocs.build/

@AA-Turner AA-Turner added the infra Core infrastructure for building and rendering PEPs label Nov 24, 2025
@AA-Turner AA-Turner requested review from a team and hugovk as code owners November 24, 2025 18:07
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We have the config for each tool in its own config file, except coverage is piggybacking on tox.ini.

Shall we put coverage it its own file too? Or use a pyproject.toml for them all?

Comment on lines +21 to +23
[coverage:report]
exclude_also =
if __name__ == .__main__.:
Copy link
Member

@hugovk hugovk Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also skip/omit/exclude release_management/__main__.py as suggested in #4704?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that already covered by the blanket exclusion?

A

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this to pull it into #4705 to test, it appears that the blanket exclusion does work, but only if there are no comments on the same line. I can't find anything in coverage's docs or GH issues about comments either way. Sorry for my error here!

@AA-Turner
Copy link
Member Author

pyproject.toml isn't the right conceptual fit. Coverage only supports .coveragerc, and I'd prefer not to have more INI-style config files.

A

@AA-Turner AA-Turner merged commit d8927bd into python:main Nov 27, 2025
22 checks passed
@AA-Turner AA-Turner deleted the tests/coverage branch November 27, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Core infrastructure for building and rendering PEPs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants