Stop updating dev fixtures for pythondotorg#117
Merged
ewdurbin merged 1 commit intopython:masterfrom Sep 8, 2017
berkerpeksag:patch-1
Merged
Stop updating dev fixtures for pythondotorg#117ewdurbin merged 1 commit intopython:masterfrom berkerpeksag:patch-1
ewdurbin merged 1 commit intopython:masterfrom
berkerpeksag:patch-1
Conversation
Member
|
thanks @berkerpeksag |
Member
|
Missed your question.... leaving that line as is is probably a good idea so that the file there can continue be served. If the generated fixtures residing there aren't replaceable we should also ensure that directory is backed up. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating dev fixtures is being replaced by python/pythondotorg#1055.
Question: I still want to keep the existing fixture available but I don't want it to be regenerated every hour. Do I need to keep the following lines as-is?
psf-salt/salt/pydotorg/init.sls
Lines 55 to 60 in b68ccd7