Avoid PowerShell command interpolation by using environment variables (hardening)#291
Merged
zooba merged 1 commit intopython:mainfrom Mar 26, 2026
Merged
Conversation
|
All commit authors signed the Contributor License Agreement. |
l3tchupkt
force-pushed
the
fix/powershell-env-hardening
branch
from
1c574f6 to
fdc6660
Compare
Member
|
Looks great, nice work. |
Contributor
Author
|
@zooba Thank you, I appreciate the review and the quick merge. Glad this approach aligns with the intended direction for improving safety in that part of the code. It was a great learning experience working through the implementation and discussion. Please let me know if there are any further improvements or related areas where I can contribute. |
Member
Not so much in this part of the project, I hope (we're mostly in careful bug fixing mode now, to minimise disruption to our users), but have a look through https://github.com/python/cpython for issues that interest you. |
Contributor
Author
|
Hi Steve,
Thank you for the guidance. I appreciate the suggestion and will look
through the CPython issues to see where I can contribute next.
Best regards,
Lakshmikanthan k
…On Fri, 27 Mar 2026, 4:42 pm Steve Dower, ***@***.***> wrote:
*zooba* left a comment (python/pymanager#291)
<#291?email_source=notifications&email_token=BNXI3G3XOWKCG3HXNMK4DNT4SZOY5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGE4DMMJRGIZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4141861123>
Please let me know if there are any further improvements or related areas
where I can contribute.
Not so much in this part of the project, I hope (we're mostly in careful
bug fixing mode now, to minimise disruption to our users), but have a look
through https://github.com/python/cpython for issues that interest you.
—
Reply to this email directly, view it on GitHub
<#291?email_source=notifications&email_token=BNXI3G3XOWKCG3HXNMK4DNT4SZOY5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGE4DMMJRGIZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4141861123>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNXI3G6ZRTBPQ52FMADF3WD4SZOY5AVCNFSM6AAAAACXA66IX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBRHA3DCMJSGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes direct string interpolation in the PowerShell fallback downloader
and replaces it with environment variable-based parameter passing.
This follows recommended practice for avoiding command construction vulnerabilities.