Skip to content

Allow fallback to WinHTTP if BITS reports 'no internet' #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 1 commit into from
Apr 15, 2026
+1 −10
Merged

Allow fallback to WinHTTP if BITS reports 'no internet' #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/manage/urlutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,17 +465,8 @@ def on_progress(_): pass
return _bits_urlretrieve(request)
except ImportError:
LOGGER.debug("BITS module unavailable - using fallback")
except NoInternetError as ex:
except NoInternetError:
request.on_progress(None)
try:
from _native import winhttp_isconnected
except ImportError:
pass
else:
if not winhttp_isconnected():
LOGGER.error("Failed to download. Please connect to the internet and try again.")
raise RuntimeError("Failed to download. Please connect to the internet and try again.") from ex

LOGGER.verbose("Failed to download using BITS, " +
"possibly due to no internet. Retrying with fallback method.")
except FileNotFoundError:
Expand Down