Skip to content

Fixes issue with tag concatenation causing default platform to override platforms #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Fixes issue with tag concatenation causing default platform to override platforms #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/manage/tagutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def is_core(self):

def __add__(self, other):
if isinstance(other, str):
return type(self)(self._company, self.tag + other)
return type(self)(self._company, self.tag + self.platform + other)
return NotImplemented

def match(self, pattern):
Expand Down
6 changes: 6 additions & 0 deletions tests/test_tagutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,9 @@ def test_tag_range_company():
assert not TagRange(r">=Company\3.10").satisfied_by(CompanyTag("OtherCompany", "3.10"))

assert TagRange("=Company\\").satisfied_by(CompanyTag("Company", "3.11"))


def test_tag_concatenate():
assert CompanyTag("3.13") + "-64" == CompanyTag("3.13-64")
assert CompanyTag("3.13-64") + "-64" == CompanyTag("3.13-64-64")
assert CompanyTag("3.13-arm64") + "-64" == CompanyTag("3.13-arm64-64")