FIX: Use ifs instead of "ternaries" #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is true so travis never reports failures.
Seluj78
approved these changes
Dec 11, 2019
Collaborator
Seluj78
left a comment
Seluj78
left a comment
There was a problem hiding this comment.
CMSB (Ça Me Semble Bon)
vpoulailleau
approved these changes
Dec 11, 2019
Contributor
vpoulailleau
left a comment
vpoulailleau
left a comment
There was a problem hiding this comment.
Nickel. Mais piégeux ce bash 😉
vpoulailleau
approved these changes
Dec 11, 2019
Contributor
vpoulailleau
left a comment
vpoulailleau
left a comment
There was a problem hiding this comment.
Nickel. Mais piégeux ce bash 😉
Member
Author
Ouai. |
Contributor
Je me suis dit ça juste après l'avoir écrit ! Mais on peut pas supprimer un commentaire, et j'ai eu un coup de flemme de l'éditer 😇 |
Collaborator
Une review * :p On peux modifier un commentaire 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because true && false || true is true so travis never reports failures.
Fixes #976