Don't include structmember.h in pythoncapi_compat.h #161
+48
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids conflicts due to names without "Py" prefixes.
Contributor
Author
|
This is the first of two issues that I ran into when pulling the latest pythoncapi_compat.h into PyTorch. We ran into name conflicts in downstream packages that had name conflicts because they pulled in both PyTorch headers and things like Thrift. |
Member
@encukou: Aha, it seems like it's time for PEP 743 – Add Py_OMIT_LEGACY_API to the Python C API :-D I hope that that PEP will be accepted. |
Member
|
Merged, thanks. I like your change, it's a nice way to avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids conflicts due to names without "Py" prefixes.