Use Box.objects.get_or_create #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

berkerpeksag merged 4 commits into python:master from jaap3:box-get-or-create

Aug 28, 2018

Contributor

jaap3 commented Aug 27, 2018

This makes it possible to create a release without installing the Box fixtures.

This should be perfectly safe as the box content is set immediately after getting/creating the box.

Contributor Author

jaap3 commented Aug 27, 2018

Looking at this again I think this could even be changed to update_or_create. Let me know if that's preferred.

This was referenced Aug 27, 2018

Add downloads factories #1317

Merged

Make sure create_initial_data is executed in the same order each time #1313

Closed

berkerpeksag reviewed

View reviewed changes

Member

berkerpeksag left a comment

You're right, changing the code to use update_or_create() would be better.

jaap3 force-pushed the box-get-or-create branch from 99caa5d to 3f9593a Compare

August 27, 2018 11:19

Contributor Author

jaap3 commented Aug 27, 2018

I've updated the PR to use update_or_create, I've also changed the use of Box.objects.get / Box.objects.get_or_create in other places

berkerpeksag reviewed

View reviewed changes

Member

berkerpeksag left a comment

This looks like a good cleanup, thanks! I only have a comment about using trailing commas after the last item of the dict.

blogs/parser.py Outdated

    
                      label='supernav-python-blog',

                      defaults={

                          'content': rendered_box,

                          'content_markup_type': 'html'

Member

berkerpeksag Aug 27, 2018

Nit: Please add a trailing comma.

downloads/models.py Outdated

    
                      label='supernav-python-downloads',

                      defaults={

                          'content': content,

                          'content_markup_type': 'html'

Member

berkerpeksag Aug 27, 2018

Nit: Please add a trailing comma.

downloads/models.py Outdated

    
                      label='download-sources',

                      defaults={

                          'content': source_content,

                          'content_markup_type': 'html'

Member

berkerpeksag Aug 27, 2018

Nit: Please add a trailing comma.

downloads/models.py Outdated

    
                      label='homepage-downloads',

                      defaults={

                          'content': content,

                          'content_markup_type': 'html'

Member

berkerpeksag Aug 27, 2018

Nit: Please add a trailing comma.

successstories/models.py Outdated

    
                          label='supernav-python-success-stories',

                          defaults={

                              'content': content,

                              'content_markup_type': 'html'

Member

berkerpeksag Aug 27, 2018

Nit: Please add a trailing comma.

Jaap Roes added 4 commits

August 28, 2018 09:38


          Use Box.objects.update_or_create

94030bd

This makes it possible to create a release without installing the Box fixtures


          Remove unused Boxes from DownloadMixin

f110e75


          Use Box.objects.update_or_create

e11ceb2


          Use Box.objects.update_or_create

fbd89f2

Remove unnecessary box creation from test cases

jaap3 force-pushed the box-get-or-create branch from 3f9593a to fbd89f2 Compare

August 28, 2018 07:39

Contributor Author

jaap3 commented Aug 28, 2018

I've added the trailing commas.

On a related note: It might be interesting to run black on this codebase at some point. That would fix a lot of existing code style inconsistencies.

berkerpeksag approved these changes

View reviewed changes

berkerpeksag merged commit 97de091 into python:master

Member

berkerpeksag commented Aug 28, 2018

Thanks!

On a related note: It might be interesting to run black on this codebase at some point. That would fix a lot of existing code style inconsistencies.

Sorry, I dislike some of the style choices of black :) Also, we don't accept cosmetic-only patches in CPython, so I'd like to follow that rule in python.org as well.

jaap3 deleted the box-get-or-create branch

August 28, 2018 10:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet