Enable to rollback sponsorship applications to editing #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how the button is being displayed in the change form. |
ewdurbin
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion in #1710 introduced the idea of having an option to rollback the sponsorship to an editable state. Me and @ewdurbin talked briefly about this and agreed that the strategy is good because it prevents the code from unexpected changes in the application via admin.
This PR mirrors the same strategy as in Accept/Reject that's using a button + a simple page to confirm the rollback operation. This code doesn't know nothing about the statement of work yet. I'll update the PR #1702 with this branch and introduce SoW's required changes in this rollback workflow.