docker: Wrong type in Container.attach()

[martinber]

I use container.attach(stdout=True, stderr=True, stream=True, logs=True) and I get a <class 'docker.types.daemon.CancellableStream'>, and when iterating over it I get each line as a bytes object which I .decode("utf-8"). My code works correctly

In mypy 1.19.1 I get

code.py:492: error: Item "str" of "str | tuple[str | None, str | None] | None" has no attribute "decode"  [union-attr]
code.py:492: error: Item "None" of "str | tuple[str | None, str | None] | None" has no attribute "decode"  [union-attr]
code.py:492: error: Item "tuple[str | None, ...]" of "str | tuple[str | None, str | None] | None" has no attribute "decode"  [union-attr]

I think the stubs are wrong on this line

typeshed/stubs/docker/docker/models/containers.pyi

Line 42 in 1be2c3f

def attach(

Thank you!

[srittau]

We should properly annotate ContainerApiMixin.attach() using overloads based on the arguments and the copy most of the signature to Container.attach. Any PRs improving the situation welcome!