Skip to content

Use proper return types for __await__ methods in redis.asyncio.client #10379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Use proper return types for __await__ methods in redis.asyncio.client #10379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78775aa
Use propert return types for `__await__` methods in `redis.asyncio.cl…
sobolevn Jun 28, 2023
468493e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stubs/redis/redis/asyncio/client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from _typeshed import Incomplete, Unused
from collections.abc import AsyncIterator, Awaitable, Callable, Iterable, Mapping, MutableMapping, Sequence
from collections.abc import AsyncIterator, Awaitable, Callable, Generator, Iterable, Mapping, MutableMapping, Sequence
from datetime import datetime, timedelta
from types import TracebackType
from typing import Any, ClassVar, Generic, NoReturn, Protocol, overload
Expand Down Expand Up @@ -67,7 +67,7 @@ class Redis(AbstractRedis, RedisModuleCommands, AsyncCoreCommands[_StrType], Asy
redis_connect_func: ConnectCallbackT | None = None,
credential_provider: CredentialProvider | None = None,
) -> None: ...
def __await__(self): ...
def __await__(self) -> Generator[Any, None, Self]: ...
async def initialize(self) -> Self: ...
def set_response_callback(self, command: str, callback: ResponseCallbackT): ...
def load_external_module(self, funcname, func) -> None: ...
Expand Down Expand Up @@ -200,7 +200,7 @@ class Pipeline(Redis[_StrType], Generic[_StrType]):
async def __aexit__(
self, exc_type: type[BaseException] | None, exc_value: BaseException | None, traceback: TracebackType | None
) -> None: ...
def __await__(self): ...
def __await__(self) -> Generator[Any, None, Self]: ...
def __len__(self) -> int: ...
def __bool__(self) -> bool: ...
async def reset(self) -> None: ... # type: ignore[override]
Expand Down